search

rabbitmq / rabbitmq-web-stomp

Provides support for STOMP over WebSockets
Other
89 stars 26 forks source link

Incompatibile SockJS! Main site uses: "0.3.4", the iframe: "0.2.1". #4

Closed redsquare closed 9 years ago

redsquare commented 11 years ago

Currently socks js requests the iframe.html file and rabbitmq/cowboy responds with an old version which has a ref to sockjs 0.2.0 (http://cdn.sockjs.org/sockjs-0.2.js)

Can the iframe html be upgraded easily inside of rabbit?

redsquare commented 11 years ago

I found the solution, need to use rabbitmq.config with the following lines (below for v 0.3.40

[ {rabbitmq_web_stomp, [ {sockjs_opts, [ {sockjs_url, "http://cdn.sockjs.org/sockjs-0.3.4.js"} ]} ]} ].

michaelklishin commented 9 years ago

Not sure if this is still relevant but we should definitely make this documented and use the most recent SockJS version out of the box.

essen commented 9 years ago

This shouldn't be the case anymore (as far as I can see anyway), however we are not using the most recent version.

We are currently using 0.3 by default. There seems to be two more recent versions: 0.3.4 (upgrading there should be easy) and 1.0.3 (seems to be mostly packaging changes so is probably easy too).

I'll take a look.

essen commented 9 years ago

Scratch the previous comment: the file included was actually 0.3.4 (got confused by the filename "0.3"). The issue the OP had was apparently long fixed.

I am about to open PRs for two related things though:

essen commented 9 years ago

Pushed three PRs updating to 1.0.3 and adding documentation about sockjs_opts.