search

rabbitmq / rabbitmq-web-stomp

Provides support for STOMP over WebSockets
Other
89 stars 26 forks source link

WIP: Implement credits flow #88

Closed essen closed 6 years ago

essen commented 6 years ago

I have manually verified that Cowboy stops reading from the socket when credit flow blocks the process.

WIP because this depends on Cowboy 2.5 which isn't out yet and will need to be updated in all relevant RabbitMQ projects first.

https://github.com/rabbitmq/rabbitmq-web-stomp/issues/40

essen commented 6 years ago

This is missing the changes in emit_stats.

essen commented 6 years ago

The flow control state is now propagated properly to management UI.

essen commented 6 years ago

Travis fails because of an Elixir version check.

michaelklishin commented 6 years ago

@essen is this still relevant since #96, as in, should this PR be closed and a new one opened on top of what we have in #96?

essen commented 6 years ago

Right this will need to be rewritten, I'll do that on Tuesday (and should release Cowboy 2.6 on Monday so this will be a good time to update and get this change merged).