rabbitmq / rabbitmq-website

RabbitMQ website
https://www.rabbitmq.com
Apache License 2.0
794 stars 717 forks source link

List supported `ack_mode` parameter values in static shovel documentation #2013

Closed mikhailantoshkin closed 1 month ago

mikhailantoshkin commented 1 month ago

Is your feature request related to a problem? Please describe.

Documentation of static shovel configuration never explicitly names variants of ack_mode that can be used in configuration. Instead, it refers to them in three different ways. As confirm being default, on-confirm and on_confirm being the only correct option.

When using an incorrect variant the error message lists available options as no_ack, on_publish and on_confirm.

Describe the solution you'd like

Refer to variants of ack_mode in a consistent way and explicitly list available variants, probably in this block

Describe alternatives you've considered

No response

Additional context

No response

michaelklishin commented 1 month ago

@mikhailantoshkin the very section you have linked to does mention all three. You can set the value to confirm even though it is the default.

I don't know what exactly "a consistent way" means to you but the parameter reference seems perfectly complete to me. I will mention all three options explicitly.

In the future, consider submitting a pull request instead of asking for a change in such generic terms.