search

rabble-rouser / Healthspek-WebSpeks

Healthspek Web Speks Developer's Guide and Quick-Start Template
0 stars 0 forks source link

Modal close triggers not obvious #4

Closed aowie1 closed 10 years ago

aowie1 commented 10 years ago

From a user perspective, after the full-screen modal is loaded, it is not obvious how to "Exit" the modal. The test links in the same actually do this but do not convey the action well to the user. Maybe the back button should change override the history state change and complete the modal close?

peterbee commented 10 years ago

Using the browser back button for this is a great idea. This follows user expectations, especially with the full-screen modal.

peterbee commented 10 years ago

@kencaron Come up with two different alternatives (in addition to the current format) for displaying test parameters and functionality. We can look at the advantages of each and decide how to best format the sample Spek.

kencaron commented 10 years ago

I agree with the back button, and should be considered a todo regardless of the options below:

(neither of which require CSS)

Option 1

Simply Add an Expected Functionality field to the current description-list format that really spells out what hitting Test should do. For example:

data-href Method
    close
Attributes
    href
        http://rabble-rouser.github.io/Healthspek-WebSpeks/page1.html
Expected Functionality
    Clicking/tapping "Test" will close both full-screen and regular modals, and send
    the plugin to the attached href.

Option 2

Method (data-href) Attribute (href) Expected Functionality
close http://rabble-rouser.github.io/Healthspek-WebSpeks/page1.html Clicking/tapping "Test" will close both full-screen and regular modals, and send the plugin to the attached href.
peterbee commented 10 years ago

Sufficiently resolved by 6d055a9bad77a67a398fccc25bce4ad85ce13864