rabblerouser / core

Pluggable, extensible membership database for community organising
GNU Affero General Public License v3.0
17 stars 10 forks source link

Make the new docker setup work on linux #151

Closed akjones closed 7 years ago

akjones commented 7 years ago

My user (uid 1000) gets mapped to the user created when node is installed in the container (uid 1000), so if I run as rabblerouser I can't npm install or anything useful because the files in the volume mount at /app are owned by my user on the host. This fix for #152 lets me override the default user I'm going to run as, and defaults to the "rabblerouser" user if $UID is not explicitly passed to ./go.sh.

akjones commented 7 years ago

Has anyone had a chance to test this on a mac yet?

camjackson commented 7 years ago

Works for me. It does print a warning though:

screen shot 2017-03-15 at 9 03 01 pm

But a getting a warning on mac is better than having it totally busted on linux. Probably fine to merge this as is, and if someone wants to fix the warning as a separate thing, then great.