Fix .travis.yml after_success to not run for pull requests

rabblerouser / core

Pluggable, extensible membership database for community organising

GNU Affero General Public License v3.0

17 stars 10 forks source link

Fix .travis.yml after_success to not run for pull requests #170

Closed ineffyble closed 6 years ago

ineffyble commented 6 years ago

Fix a bug in Travis scripts, where pull requests against the master branch trigger docker-build-and-deploy (which then hangs due to lack of Docker Hub credentials).

From Travis docs:

TRAVIS_BRANCH:

for push builds, or builds not triggered by a pull request, this is the name of the branch.
for builds triggered by a pull request this is the name of the branch targeted by the pull request.
for builds triggered by a tag, this is the same as the name of the tag (TRAVIS_TAG).

camjackson commented 6 years ago

Woww, that's super unexpected. I suspect we have the same bug in all of our travis configs, so we might need to do some copy-pasting to fix this everywhere 😞

camjackson commented 6 years ago

Ok I think that's got all of them. Will have to remember for any future new builds.