rabblerouser / core

Pluggable, extensible membership database for community organising
GNU Affero General Public License v3.0
17 stars 10 forks source link

Modals aren't closing properly #94

Closed camjackson closed 7 years ago

camjackson commented 7 years ago

There are a couple of modals that don't seem to close when they should.

Looks like the issue is to do with action creators not being bound correctly in the components. There's an action being imported here, from a reducers file. It's probably meant to be imported from the actions file instead. It's also not being bound correctly on line 29 (i.e. it's binding the imported action creator directly, not the bound one from this.props.

Looks as though the same problem is present in this file.

Acceptance criteria:

camjackson commented 7 years ago

@yearofthedan This is the issue I mentioned to you yesterday.

camjackson commented 7 years ago

Fixed in 5f7e12ceef08d8dd120b4c89df54c8a8518a89bc