rabeehk / compacter

126 stars 15 forks source link

About calculate trainable params #11

Open CaffreyR opened 2 years ago

CaffreyR commented 2 years ago

Hi Rabeeh, in your code, you calculate the total_params_ratio by using this code.

total_params_ratio = ((total_params-t5_base_params)*8+t5_base_params)/t5_base_params

https://github.com/rabeehk/compacter/blob/main/seq2seq/utils/utils.py#L213

Why do your multiply 8 instead of just divide? Many thanks