search

rabidaudio / gulp-inline-image-html

Gulp task inlining images in HTML
MIT License
9 stars 8 forks source link

Refactored with better documentation and fix regression in 4968444 #4

Closed specious closed 5 years ago

specious commented 6 years ago

Stream transform function should not be checking for existence of file (4968444), and it's a chunk not a file.

This refactoring clarifies a number of things, including the optional base directory parameter and the relationship between this module, @maxogden's inline-images and the through2 stream transform API.

specious commented 6 years ago

@rabidaudio, please take a quick look 👍

CREEATION commented 5 years ago

@rabidaudio please deprecate the package if you don't plan to update it.

rabidaudio commented 5 years ago

Thanks for this! Sorry about the delay, this slipped by me. 0.2.3 is now published.