search

rabite0 / hunter

The fastest file manager in the galaxy!
Do What The F*ck You Want To Public License
1.31k stars 64 forks source link

Publish release? #1

Closed wezm closed 5 years ago

wezm commented 5 years ago

This looks like a really well built tool. I'd love to create and AUR package for hunter. It's best to build these against published releases instead of straight from git master though. I would be great if you could tag a release.

rabite0 commented 5 years ago

Thank you! I meant to do that anyway, but forgot. I shamelessly tagged this with 1.0 now :'), does that work for you?

EDIT: Changed to annotated tag.

cpdean commented 5 years ago

Also it looks like you haven't made a crate of this yet. if you do a cargo publish then everyone can install this with cargo install hunter.

rabite0 commented 5 years ago

Oh, yes, you're right. Will do that when I get home.

rabite0 commented 5 years ago

Do you know if there's a way to change the branch from which the binary gets built? I should probably change the default keybindings around anyway, but still.

EDIT: Crate uploaded.

wezm commented 5 years ago

Thank you. It looks like someone beat me to publishing an AUR package: https://aur.archlinux.org/packages/hunter/

It looks like hunter requires nightly Rust. It would be great if you added a rust-toolchain file to the root of the repo with the version you're using so people can replicate that version and guarantee a successful build.

rabite0 commented 5 years ago

Thank you too, your suggestions are really appreciated. Sorry to hear, that someone snatched the packaging it under your nose, but thanks to that person, too! :)

I added a rust-toolchain file, like you said, someone had problems compiling hunter, probably because of a too old nightly compiler. Sadly, there doesn't seem to be a way to just specify a minimum version, but it'll do. I hope I did this right. Thanks again.

wezm commented 5 years ago

Thanks for building a great tool. :) Unfortunately there's no good way to specify a minimum Rust version. There's ongoing discussion about implementing it at https://github.com/rust-lang/rfcs/pull/2495

rabite0 commented 5 years ago

Too bad.. Alright, closing this now. +1: