search

rabix / bunny

[Legacy] Executor for CWL workflows. Executes sbg:draft-2 and CWL 1.0
http://rabix.io
Apache License 2.0
74 stars 28 forks source link

Support for ECMAScript 6.0 in rabix executor and composer #451

Open zymergen-mbarton opened 5 years ago

zymergen-mbarton commented 5 years ago

Would it be possible to provide support for ES6 in rabix executor?

My understanding is that CWL 1.0 is ES5.1 and CWL 1.1 is ES6. The cwltool executor however provides support via an additional requirement (common-workflow-language/common-workflow-language#329)

requirements:
  cwltool:ECMAScriptVersionRequirement:
    ecmascriptVersion: 6

Would it be possible to do something similar for rabix in the mean time?

ghost commented 5 years ago

Hi @zymergen-mbarton , could you share the CWL you are trying to run (private message is fine, if this is confidential). Rabix Executor runs both ES5 and ES6 and does not require strict mode like CWLtool and toil do. For this reason it is a more admissive executor. It would be helpful to see what expression is failing on RE. Thanks!

zymergen-mbarton commented 5 years ago

Thank you Kaushik, I have emailed you the file privately.

On Mon, Jan 28, 2019 at 7:58 AM Kaushik Ghose notifications@github.com wrote:

Hi @zymergen-mbarton https://github.com/zymergen-mbarton , could you share the CWL you are trying to run (private message is fine, if this is confidential). Rabix Executor runs both ES5 and ES6 and does not require strict mode like CWLtool and toil do. For this reason it is a more admissive executor. It would be helpful to see what expression is failing on RE. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rabix/bunny/issues/451#issuecomment-458188583, or mute the thread https://github.com/notifications/unsubscribe-auth/AjMMneBb-AnllS3BEuJHijwKVkD4N88uks5vHx4ngaJpZM4aR5NV .