rabobank-cdc / DeTTECT

Detect Tactics, Techniques & Combat Threats
GNU General Public License v3.0
2.04k stars 331 forks source link

Excel output for Visibility refers to Detection score, not Visibility score #93

Closed tailsec closed 1 year ago

tailsec commented 1 year ago

When looking to visualise the Visibility for the Credential Stuffing technique, the yaml file shows there are different scores for Detection (-1) and Visibility (2)

image

Generating the Excel output gives a value of -1, which appears to stem from the Detection score:

(venv) user@ubuntu:/opt/DeTTECT$ python dettect.py v -ft sample-data/techniques-administration-endpoints.yaml -e
File written:   output/techniques.xlsx

image

Whereas generating a Navigator Layer provides the correct value of 2:

(venv) user@ubuntu:/opt/DeTTECT$ python dettect.py v -ft sample-data/techniques-administration-endpoints.yaml -l
File written:   output/visibility_example_1.json

image

rubinatorz commented 1 year ago

hi @tailsec

In the excel file there are two worksheets. One for detections, one for visibility. The one in your screenshot is for detections, so please look at the second sheet in that file. There you will find the visibility view.