raboof / nethogs

Linux 'net top' tool
GNU General Public License v2.0
3.19k stars 289 forks source link

determineVersion.sh: prevent traversing into outer git repo for git-describe call #279

Closed BubuOT closed 1 month ago

BubuOT commented 1 month ago

When building nethogs inside another git repo (as is i.e. done as part of a buildroot build) the version is picked up from the outer git repo, which is confusing as well as introducing reproducibility problems when rebuilding the same nethogs version produces different results if the outer repository changes.

raboof commented 1 month ago

Thanks! Were you at the r-b summit? I couldn't make it this year sadly!

BubuOT commented 1 month ago

That was fast! :-)

Yep, I was there. Only for two days though, as my time in the moment is also a bit limited.