search

raboof / notion

Tiling tabbed window manager
https://notionwm.net/
GNU Lesser General Public License v2.1
271 stars 64 forks source link

SDL2 based applications cannot enter full screen #244

Closed grapeli closed 4 years ago

grapeli commented 4 years ago

In the case of a dosbox, it looks like this. https://drive.google.com/open?id=1xXkl0EXJbghDgNhVl__95LPfpqAUFV8F Pre-build dosbox-staging.

The same happens for the test application testdraw2 which is the source part of SDL2.

Both work without problems under i3. I don't know where the problem is. In sdl2, xorg or maybe notion? How to diagnose and fix it. Everything takes place under archlinux.

Is this problem similar to Adobe Flash fullscreen? https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=462690 or https://bugzilla.libsdl.org/show_bug.cgi?id=1859

grapeli commented 4 years ago

After applying this patch to SDL2, finally the applications correctly enter fullscreen under notion. The problem can be solved.

raboof commented 4 years ago

Cool! What upstream issue was this patch attached to?

grapeli commented 4 years ago

Cool! What upstream issue was this patch attached to?

No. I am not a developer to pull this topic and justify it properly. However, it is worth looking at even more closely. If you feel up to it, do it. I test so.

curl -JOL https://www.libsdl.org/release/SDL2-2.0.10.tar.gz
tar xf SDL2-2.0.10.tar.gz
cd SDL2-2.0.10
./configure --prefix=/usr --disable-shared
make -j4
cd test/
gcc -o testdraw2 testdraw2.c -g -O2 -I../include -D_REENTRANT -DHAVE_OPENGLES2 -DHAVE_OPENGL -L../build/.libs -lSDL2_test -lSDL2 -pthread -lm -ldl -lrt -lunwind-x86_64 -lunwind
./testdraw2 --help
./testdraw2 --info all   #fullscreen alt-enter

I noticed that the fullscreen with software renderer works fine even after undoing this commit. SDL_RENDER_DRIVER=software ./testdraw2 --info all

grapeli commented 4 years ago

A broken fullscreen in SDL2 was finally fixed five days ago. Finally!