search

raboof / notion

Tiling tabbed window manager
https://notionwm.net/
GNU Lesser General Public License v2.1
268 stars 63 forks source link

Xinerama crashing bug on non-xinerama screens #289

Closed kristopolous closed 4 years ago

kristopolous commented 4 years ago

There's a possibility of a null pointer returned by XRRGetScreenResources in mod_xrandr_get_outputs_for_geom. It wasn't getting checked. Now it is.

raboof commented 4 years ago

Fixes #288

kristopolous commented 4 years ago

I don't know tbh... I certainly don't have enough experience with this codebase to be able have an opinion on preemptive protections, it wasn't crashing out on me

raboof commented 4 years ago

I certainly don't have enough experience with this codebase to be able have an opinion on preemptive protections, it wasn't crashing out on me

Well, given that we now know XRRGetScreenResources can return null in some situations, I think we should make sure mod_xrandr_get_all_outputs doesn't crash in that situation ;). Filed #292