raboof / notion

Tiling tabbed window manager
https://notionwm.net/
GNU Lesser General Public License v2.1
268 stars 63 forks source link

Frame Tile Background / Border #297

Open fantasai opened 3 years ago

fantasai commented 3 years ago

Hello! I just upgraded my OS, and Notion (3-20150613 to 4.0.1) along with it. :) First off, thanks for maintaining this window manager to which I am hopelessly addicted. There were a couple cosmetic things I haven't gotten to work again yet, though:

I saw that you updated the docs for a few other changes (<3) but nothing in this area, so I'm guessing it's a bug.

fantasai commented 3 years ago

Ah, forgot to mention, I was using look_cleanviolet.lua

fantasai commented 3 years ago

And the fix seems to be reordering the file as follows:

  1. base and tab styles
  2. dopath("lookcommon_clean")
  3. frame styles

I have no idea why.

raboof commented 3 years ago

thanks for maintaining this window manager to which I am hopelessly addicted

Thanks, same here :D

And the fix seems to be reordering the file as follows

Does that fix both the backgroudn and the thin borders? We had to reimplement some of the look loading/hierarchy logic (#197), and it is indeed possible that it behaves slightly different now. Is there anything that needs to change to the default looks?

fantasai commented 3 years ago

@raboof Yes, it fixes both. I don't know why. There's something about how you cascade the styles that's different than before, and I haven't figured out what the differences are or why this results in a fix. Probably all the look.cfg files that use dopath() will need adjustment as a result?

wilhelmy commented 1 year ago

@fantasai is there any visible difference in notion's stderr output?