search

raboof / notion

Tiling tabbed window manager
https://notionwm.net/
GNU Lesser General Public License v2.1
272 stars 65 forks source link

Use Lua 5.4 if it is found #306

Closed wilhelmy closed 3 years ago

wilhelmy commented 3 years ago

This closes #305 once merged. Please test, but I don't see anything here https://www.lua.org/manual/5.4/manual.html#8 that we would probably trip over.

raboof commented 3 years ago

nice! if I'm reading https://archlinux.org/packages/extra/x86_64/lua/ right they're already using 5.4

nixos doesn't have 5.4 yet (https://github.com/NixOS/nixpkgs/issues/99261), I'll look into that a bit so I can test ;)

raboof commented 3 years ago

@wilhelmy do you want to keep this WIP or is this ready to go?

wilhelmy commented 3 years ago

No, I just figured we should test it somewhat extensively, but since master isn't due for release so soon, maybe now would be a good time to merge it.

wilhelmy commented 3 years ago

I've been running this for a few days now and it seems stable. Anyone notice any breakage?

raboof commented 3 years ago

Seems healthy here!