search

raboof / notion

Tiling tabbed window manager
https://notionwm.net/
GNU Lesser General Public License v2.1
272 stars 65 forks source link

Moving ~/.notion to ~/.config/notion. #310

Open Scupake opened 3 years ago

Scupake commented 3 years ago

If that's currently possible, please show me how to do it, since I can't find anything about it. If it's not, I would like you to consider following the XDG spec.

raboof commented 3 years ago

Perhaps we should support both, to make it less painful for existing users?

Would you be interested in preparing a PR?

raboof commented 3 years ago

Currently, I wonder if adding it to the search path with the -s parameter would work?

Scupake commented 3 years ago

Perhaps we should support both, to make it less painful for existing users?

Maybe make it check if ~/.config/notion exists, if it does use that, if it doesn't it uses ~/.notion.

Would you be interested in preparing a PR?

uhhh, what do you mean exactly? Adding the code? or just an empty WIP PR?

raboof commented 3 years ago

Perhaps we should support both, to make it less painful for existing users?

Maybe make it check if ~/.config/notion exists, if it does use that, if it doesn't it uses ~/.notion.

That makes sense to me. Looking for all resources in both locations might also be fine.

Would you be interested in preparing a PR?

uhhh, what do you mean exactly? Adding the code? or just an empty WIP PR?

Adding the code ;)

Scupake commented 3 years ago

Oh, well I'm not very good at C, but I'll try to.

md1023 commented 3 years ago

Symbolic links work well on my Linux installations:

23:40:43 pwd
/home/mnikolaev
23:40:52 ls -al .notion
lrwxrwxrwx 1 mnikolaev mnikolaev 50 янв 15 20:04 .notion -> /home/mnikolaev/Documents/olivetti/configs/.notion/

Is that desirable or you want to get rid of ~/.notion completely?

Scupake commented 3 years ago

I want to get rid of it completely, home dir clutter annoys me a lot

wilhelmy commented 3 years ago

Other than that, I'm fine with supporting both locations.

wilhelmy commented 3 years ago

I think to formally support ~/.config properly, also the XDG_CONFIG_HOME variable needs to be handled. Also the history shouldn't go into ~/.config/notion but ~/.local/share/notion or something like that. Haven't read the full spec: https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html

Edit: might be a good way to learn a little C, this seems like a simple task.

Scupake commented 3 years ago

Yeah, it's good idea. But just supporting ~/.config is enough for me. I'll try to add support for the XDG spec , gonna take a while though since I'm really bad at programming in general and have never used C before.

EDIT: Maybe rename the issue to "XDG specification support."?

raboof commented 3 years ago

But just supporting ~/.config is enough for me.

I think first 'simply' adding support for ~/.config and leaving more sophisticated support for future PR's would be fine.

gonna take a while though since I'm really bad at programming in general and have never used C before.

If you run into any roadblocks feel free to ask! I think it's great that you're even considering this at all!

Maybe rename the issue to "XDG specification support."?

All of XDG is very broad, I think it's fine to have separate issues about various parts.

wilhelmy commented 3 years ago

@Scupake if you need any help, I think I have enough time on my hands again to give some IRC support/mentoring. Speaking from personal experience, messing with things you're kind of clueless about is a fun way to learn stuff, if that's what you're after.