search

raboof / notion

Tiling tabbed window manager
https://notionwm.net/
GNU Lesser General Public License v2.1
272 stars 65 forks source link

mod_sp: unused code around scratch workspaces #319

Open wilhelmy opened 3 years ago

wilhelmy commented 3 years ago

mod_sp handles the scratchpad and scratch workspaces. scratch workspaces are dead code.

wilhelmy commented 3 years ago

Does anyone here remember scratch workspaces and whether or not they ever did something useful?

mjf commented 1 year ago

In general, to create "scratch workspace" with a pre-defined layout and hide and show it on demand (both actions configured to a simple keypress such as META+Mod1+Space to show and META+Mod1+Space again to hide it) would be splendid feature. I've also never used the scratch workspaces from the mod_sp but I extensively use regular scratchpad (META+Space) all the time and I can imagine some sort of "scratch workspaces" as I described would be pretty useful feature. It is achievable with Lua?

wilhelmy commented 1 year ago

I was talking about dead C code in mod_sp. I agree that scratchpads are great, but that isn't what this issue is about. For feature requests, please open a new issue. Edit: or, more ideally, a pull request ;)

mjf commented 1 year ago

scratch workspaces are dead code.

@wilhelmy I must have mistunderstood this issue. I thought it's about removing scratch workspaces completely. Therefor I tried to defend the idea and also ask if replacement in Lua exist, so... ?

wilhelmy commented 1 year ago

There's scratchpads and so-called scratch workspaces. The way I understand/remember it, scratch workspaces are a separate concept that's also handled by mod_sp but currently dead code. If no one remembers what they were supposed to do, I'd propose removing the dead code, or make it work by some other means.

Then again, dead code isn't really that much of a burden.