search

raboof / sfarkxtc

Basic sfArk decompressor
GNU General Public License v3.0
96 stars 17 forks source link

Works only for sf in current dir #5

Closed fiee closed 4 years ago

fiee commented 9 years ago

If you try to call the tool with a complete path like

./sfarkxtc /Users/me/SoundFonts/Fluid.sfArk /Users/me/SoundFonts/Fluid.sf2

it fails with errorcode 9 (at least on OSX). It works, if you cd to the soundfont’s directory.

Please at least document, that it doesn’t work with paths, but only with files.

raboof commented 9 years ago

Indeed you currently have to cd to the target directory. I'd prefer fixing that ;)

moltenform commented 5 years ago

I have a fix for this, in my fork at https://github.com/moltenform/sfarkxtc-windows I can make a PR if it would be useful. I also fixed the name handling to make it consistent (e.g. without my patch, notes files are written out to a path based on the original sf2 filename).

raboof commented 5 years ago

A PR would be great!

moltenform commented 5 years ago

PR sent, https://github.com/raboof/sfArkLib/pull/13

moltenform commented 5 years ago

Thoughts?

moltenform commented 4 years ago

I think this issue can be closed, my PR back in june 2019 (https://github.com/raboof/sfArkLib/pull/13) fixes the issue.

raboof commented 4 years ago

Indeed looks like we forgot to close this one, thanks again!