Open renatomello opened 3 weeks ago
Hi Renato,
this is great, thanks for providing you qibo integration code. I'll have a look at it soon an will let you know about the merge status.
Btw., I also saw your really nice robust shallow shadows paper comming out recently, huge congrats!
Best, Raphael
Von: Renato Mello @.>
Gesendet: Montag, 16. September 2024 08:28
An: rabrie/mGST @.>
Cc: Raphael @.>; Mention @.>
Betreff: [rabrie/mGST] Integration with Qibo
(PR #11)
Hello @rabriehttps://github.com/rabrie and @padirohttps://github.com/padiro,
I forked this repo and created a functioning version of the code integration with the Qibo package for circuit generation and optimization.
Would you guys be interested in merging this into your main branch? You can review the changes I made. Also, if this is not in the interest of the project, feel free to just close this PR.
In any case, thanks for the nice package.
You can view, comment on, or merge this pull request online at:
https://github.com/rabrie/mGST/pull/11
Commit Summary
qibo
implementationFile Changes
(6 fileshttps://github.com/rabrie/mGST/pull/11/files)
Patch Links:
— Reply to this email directly, view it on GitHubhttps://github.com/rabrie/mGST/pull/11, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMX6X3QH4B6236EQGDHQXU3ZWZ3B3AVCNFSM6AAAAABOITNWUWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUZDONRQHE2TGNY. You are receiving this because you were mentioned.Message ID: @.***>
Hello @rabrie and @padiro,
I forked this repo and created a functioning version of the code integration with the
Qibo
package for circuit generation and optimization.Would you guys be interested in merging this into your main branch? You can review the changes I made. Also, if this is not in the interest of the project, feel free to just close this PR.
In any case, thanks for the nice package.
PS: I also replaced the use of the built-in
random
package withdefault_rng
fromnumpy
because it is slightly faster for largesequence_numbers
and increasedsequence_length
.