search

rabser / moodle-auth_googleoauth2

Oauth2 authentication plugin for Moodle (for Moodle 3.2 and earlier)
GNU General Public License v3.0
78 stars 78 forks source link

Add a missing .gitmodules reference #204

Closed OdyX closed 8 years ago

OdyX commented 8 years ago

Add pixealfear/oauth2-dropbox from the mouneyrac fork

mouneyrac commented 8 years ago

Hi Didier, what is this for? Composer should install the dropbox provider when following the README.md. I don't think we need a git submodule? PS: these were geniune questions, I suppose there is a process reason to have the dropbox provider as a git rep. Is that to be able to commit change easily?

OdyX commented 8 years ago

Hi @mouneyrac,

we're using submodules for all possible Moodle plugins we use, and the fact that the directory is present, but empty, breaks some assumptions of "some part of Moodle I don't remember right now".

Also, without this commit, this branch has a https://github.com/mouneyrac/moodle-auth_googleoauth2/tree/master_with_vendor/vendor/pixelfear vendor/pixelfear directory registered as git submodule, but no .gitmodules file to let git know where it is supposed to get this directory's content from.

My commit fixes this offset.