Closed rabuchaim closed 8 months ago
The calculation is correct and no duplicate networks were found in the CSV file.
The problem occurs on the IPv6 network that was inserted in the reserverNetworks variable.
"fd00::/8": {"15":"Reserved for Unique Local Addresses"}
This network is being considered in calculations even for IPv4 and it should not be.
It will be fixed in the next version. And this does not impact search accuracy, since IPv6 converted to integer is much larger than any IPv4 in integer.
In the CSV of 2023-10-17 we have the highest GeoIP coverage ever recorded since the launch of GeoIP2Fast, we have 99.65% coverage!
[DEBUG] - Country IP coverage 99.65%
In short:
Fixed in version v1.1.3
Coverage is greater than 100% with Maxmind CSV files from 2023-10-17
Possible a duplicated network inside CSV files.
Requires a detailed check and a function that prevents entering duplicate networks. Currently, geoip2dat.py generates dat files from what is contained in the Maxmind files and does not check for network duplicity.
The coverage calculation lists all included networks, calculates how many IPs there are in each network, sum up these IPs and compares them with the maximum possible IPv4, which is 4294967296 IPs.
This does not affect search accuracy.