search

raburton / rboot

An open source bootloader for the ESP8266
https://richard.burtons.org/tag/rboot/?order=ASC
MIT License
300 stars 72 forks source link

move RBOOT_INTEGRATION handling to rboot.h #30

Closed jacmet closed 7 years ago

jacmet commented 7 years ago

Everything including rboot.h need to take RBOOTINTEGRATION into consideration as rboot.h contains BOOT* #ifdefs, so move the RBOOT_INTEGRATION handling to there instead of repeating it everywhere (and risk forgetting it, like it was the case for rboot-api.h).

Signed-off-by: Peter Korsgaard peter@korsgaard.com

raburton commented 7 years ago

There was a reason for not doing that, I think it was to allow people to use a different rBoot.h file of their own (which could #define #define __RBOOT_H__ to keep the original out). I know it used to be used this way by Sming, but doesn't look like it is does this anymore so it's probably ok to change.