Closed jacmet closed 7 years ago
Again, I'm sure there was a reason for not doing this before, because this would be the most obvious thing to do. Really can't remember what it was though! Might have been to do with compatibility with different (earlier) versions of the SDK, which wouldn't really matter now. Mind you, does this change compile with the RTOS SDK as well as the standard?
I've never used the RTOS SDK, but looking at https://github.com/espressif/ESP8266_RTOS_SDK/blob/master/include/espressif/c_types.h the content looks very similar and has the needed typedefs, so I would say yes.
Do you want me to rebase this commit so it applies now that you applied the rboot-integration change?
I've rebased the commit now.
thanks
rboot.h uses the nonstandard uint8 / uint32 types without defining them, causing breakage if rboot.h (or other headers including it like rboot-api.h) are included without locally defining these types.
The espressif SDK includes a nonstandard c_types.h header containing definitions for uint8/uint32/TRUE/FALSE, so include that in rboot.h and drop all the local definitions.
Signed-off-by: Peter Korsgaard peter@korsgaard.com