Fix completion when company-mode is not available

racer-rust / emacs-racer

Racer support for Emacs

399 stars 48 forks source link

Fix completion when company-mode is not available #112

Closed ghost closed 5 years ago

ghost commented 5 years ago

:exit-function is actually not an company-mode specific thing. Other completion mechanisms may use it as well. The first commit disables it when company-mode is not installed.

The second commit adds an option to turn off this feature, because I saw this comment.

Thanks!

coveralls commented 5 years ago

Coverage decreased (-0.3%) to 62.637% when pulling e4042c29db07e2cde1d5b281460822d1e88f164b on zhangpj:fix-capf into bf8f76f17c64eff2d6ca6029ee0ab7a466590128 on racer-rust:master.

kngwyu commented 5 years ago

Thanks!

ghost commented 5 years ago

I just found that this feature stopped working (with or without this patch). There might be some changes in company-mode.

I am investigating it. Please hold on.

ghost commented 5 years ago

That issue was fixed in company-mode: https://github.com/company-mode/company-mode/commit/aabf0a35df3d1507b9341bdf7a5afa3ee9f18c17.

Do you mind merging this PR?

kngwyu commented 5 years ago

Sorry I forgot to merge it...