racer-rust / emacs-racer

Racer support for Emacs
398 stars 48 forks source link

Packaging fixes #70

Closed purcell closed 7 years ago

purcell commented 7 years ago
coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 64.535% when pulling 76282be0650a1eca5bf9a20a598b06325706c56d on purcell:patch-1 into 2975da255dd1c9f244f314885af8fb84c9f3fe54 on racer-rust:master.

Wilfred commented 7 years ago

Thanks.

I don't think your new package summary quite summarises what this package does. racer.el is not just completion: it supports going to definition, eldoc, and rendering help from rustdoc markdown docstrings.

I added 'official' to distinguish from the ac-racer and company-racer packages. The repos in the racer-rust GitHub organisation are official and the racer core devs contribute to them.

Other glue packages include 'A Git porcelain inside Emacs', 'Emacs integration for gist.github.com', 'Emacs interface to Google Translate.' on melpa.org. What do you think would be a better summary?

purcell commented 7 years ago

I don't think your new package summary quite summarises what this package does. racer.el is not just completion: it supports going to definition, eldoc, and rendering help from rustdoc markdown docstrings.

Oh, I copied it from the docstring of the custom group, so maybe that needs fixing too.

I don't care too much, but mention of Emacs in the description of an elisp package is always redundant, and those other examples you found would ideally get fixed up too.

Wilfred commented 7 years ago

Oh, I copied it from the docstring of the custom group, so maybe that needs fixing too.

Thanks, I hadn't spotted that.

This should now be fixed in ca5b2f2 -- does that look better to you?

purcell commented 7 years ago

Yep, great!