search

racer-rust / racer

Rust Code Completion utility
MIT License
3.36k stars 279 forks source link

Cargo update #1048

Closed topecongiro closed 5 years ago

topecongiro commented 5 years ago

Update rustc-ap-syntax to 491.0.0.

Note that I am just passing edition 2018 to syntax::with_globals. Ideally, we should pass the correct edition to it, but I find it to require quite a lot of code refactoring, and I basically gave up. Since the current implementation of racer does not seem to properly set the correct edition anyway, I am assuming that there will be no breaking change introduced with this PR.

topecongiro commented 5 years ago

cc https://github.com/rust-lang/rustfmt/pull/3611.

kngwyu commented 5 years ago

Thanks!

Since the current implementation of racer does not seem to properly set the correct edition anyway, I am assuming that there will be no breaking change introduced with this PR.

Thanks you for trying that. The problem is calling cargo metadata can be slow but anyway we have to do do that

topecongiro commented 5 years ago

Could you make a point release so that we could update the dependencies of rls?

kngwyu commented 5 years ago

Sure. Now I'm doing some bug fixes and I'll release it by today.

kngwyu commented 5 years ago

Released 2.1.23 now.

topecongiro commented 5 years ago

@kngwyu Thank you!