search

racer-rust / racer

Rust Code Completion utility
MIT License
3.36k stars 278 forks source link

Bump rustc-ap crates to 670 #1123

Closed tmandry closed 4 years ago

tmandry commented 4 years ago

To fix rls and rustfmt again.

cc https://github.com/rust-lang/rust/issues/74081 https://github.com/rust-lang/rust/issues/74080 cc @topecongiro @Xanewok @calebcartwright

tmandry commented 4 years ago

CI failure looks spurious (due to https://github.com/rust-lang/rustup/issues/2434). I ran a build locally and it succeeded.

calebcartwright commented 4 years ago

We've just about finished the process to get things fixed using v669, and bumping to v670 will require us to start the process all over again. Things are compiling fine for me using v669 with rustc 1.47.0-nightly (0820e54a8 2020-07-23), so is there anything specific needed in v670 that's worth the added delay?

If not I'd really prefer to see the bumps with v669 through to completion first

tmandry commented 4 years ago

Sorry, I misunderstood the problem. I'll close this for now because I also want to get things green again.

If there's anything I can do to help with that, I'd be happy to :)

calebcartwright commented 4 years ago

No worries! All that's left now is bumping the rustfmt and racer versions in rls, and then updating the two submods in rust-lang/rust.

Not sure if that'll be done via https://github.com/rust-lang/rls/pull/1689 or a different one @Xanewok may be working on

Xanewok commented 4 years ago

https://github.com/rust-lang/rls/pull/1689 is now merged, sorry for the wait :(