Adapt to the new standard library directory layout

racer-rust / racer

Rust Code Completion utility

MIT License

3.36k stars 278 forks source link

Adapt to the new standard library directory layout #1130

Closed Xanewok closed 4 years ago

Xanewok commented 4 years ago

Refs: https://github.com/rust-lang/rust/pull/73265

@kngwyu Does that look acceptable? I'm somewhat torn where should I add a new fallback and where I should just straight up replace the old path logic. I think it makes sense to wholly replace it since Racer is tied to the version of Rust that distributes the rustc-ap-* library set it depends on but I'm not sure how much we'd like to maintain backwards-compat for older Rust toolchains...

kngwyu commented 4 years ago

Thanks!

but I'm not sure how much we'd like to maintain backwards-compat for older Rust toolchains...

Since it is not very difficult to try both of pathes, I'll add some fallbacks for macros and premitives later.

Xanewok commented 4 years ago

Just tested this on Windows and the first run seem to have failed but other subsequent cargo test runs succeed. Tried with and without RUST_SRC_PATH set both in Powershell and in mingw-w64. Maybe it's due to stale build cache?