search

rachelkeh / pe

0 stars 0 forks source link

missing multiplicities in class diagram #8

Open rachelkeh opened 2 years ago

rachelkeh commented 2 years ago

image.png

nus-se-script commented 2 years ago

Team's Response

This is a partial class diagram just like in the AB3 below. Duke does not initialize a parser class. This diagram is more to just show the overall structure of the Logical component.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Firstly, DG mentioned this was a class diagram. Can be more specific and say is partial class diagram if not I just treated this diagram as a normal class diagram since it's not like prof taught partial class diagrams and I'm supposed to be aware of this. image.png Secondly, there is a multiplicity in the AB3 diagram from LogicManager to AddressBookParser. Not sure why there isn't from LogicManager to Storage and Model, might be because they aren't classes but an entity maybe (is this even legal because can class diagrams even include complex entities that aren't classes, interfaces and abstract classes etc)? Also, prof never told us that everything in AB3 is correct and told be followed. He only told us to follow the structure and follow the description of an implementation on AB3 as shown on the images below. Because I'm not exactly sure how partial class diagrams work, since the prof didn't teach, I googled it and most of the images show multiplicities on the partial class diagrams. Link below.

image.png

image.png

https://www.google.com/search?q=partial+class+diagram&rlz=1C1CHBF_enSG794SG794&sxsrf=AOaemvKvAB3hVOkdT6WgZN3k8E0YeZVdDQ:1637249657869&source=lnms&tbm=isch&sa=X&ved=2ahUKEwjNt4-inqL0AhWRTX0KHTN_DUYQ_AUoAXoECAEQAw&biw=1280&bih=609&dpr=1.5#imgrc=wIrxjqynzoZSJM

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.High]

Reason for disagreement: Issue severity isn't verylow since this issue isn't a small cosmetic issue but one with functionality impact as my understanding of the classes are affected. Should be low/medium.