search

rachelkeh / pe

0 stars 0 forks source link

return values in sequence diagram #9

Open rachelkeh opened 2 years ago

rachelkeh commented 2 years ago

image.png

can consider showing the return values in the sequence diagram so that users can understand the sequence diagram better

nus-se-bot commented 2 years ago

Team's Response

We feel that the labels for return values are not necessary in this case as it does not omit any relevant information.

As per CS2113T website:

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Some of the functions executed here are big functions (not a simple get function which can be explained by the name of the function) where the return values are not absolutely clear like the return value of "delete 1/2" from duke to user, execute() from duke to deletecommand and maybe even deleteParticularOrder(2) from deletecommand to manager. Would make the interactions between components a lot clearer if these return values were added.