search

rachelktyjohnson / hktbf22-quiz-app

See the live version here: https://rachelktyjohnson.github.io/hktbf22-quiz-app
1 stars 7 forks source link

Scramble the display order of answer options #2

Closed rachelktyjohnson closed 12 months ago

rachelktyjohnson commented 2 years ago

This is too easy!

You must be assigned this issue in order for your Pull Request to be accepted and merged. Please refer to "How to claim an Issue here: https://github.com/rachelktyjohnson/hktbf22-quiz-app/blob/master/CONTRIBUTING.md#how-to-claim-an-issue

You may have noticed by now that the correct answer is always displayed first. That's no good! Your task is to shuffle the order in which the answers appear on the grid.

There are a few ways to do this, but our recommendation is to do this within the addQuestionToDisplay() method in question.js

You must not change the data structure of data.js.

Lyndsayfutrell commented 2 years ago

Okay I think I will give this one a go. Slack handle Lyndsay Futrell. FSJS tech degree 🤓

rachelktyjohnson commented 2 years ago

@Lyndsayfutrell all yours!

S-ahil-Saxen-a commented 2 years ago

Hey @rachelktyjohnson , I have made this type of feature before, so please assign it to me also under hacktoberfest'22 Slack Handle: Sahil Saxena Tech Degree: Java Script

fauxriarty commented 12 months ago

Hey! I'd love to work on this if it's still open.

rachelktyjohnson commented 12 months ago

@fauxriarty go ahead! Keen to see what you do 😁

fauxriarty commented 12 months ago

I just forked the repo and went through the code, it already randomizes the order of options displayed so theres nothing left for me to do, unless you have a suggestion (for hacktoberfest haha)

rachelktyjohnson commented 12 months ago

@fauxriarty oh dear my apologies! I must have missed this last year 🙈

You're welcome to have a look at issue#1 as anyone can add to that one! Otherwise I'm more than happy to see what additions/fixes you come up with 😁

fauxriarty commented 12 months ago

Hey I made a PR with a few changes. Check and let me know what you think :)

rachelktyjohnson commented 12 months ago

@fauxriarty just merged it! Although it looks like there might be a bug now

rachelktyjohnson commented 12 months ago

@fauxriarty might be able to get another PR in ;)