search

rachelss / SISRS

Site Identification from Short Read Sequences.
24 stars 15 forks source link

RAL Python #65

Closed BobLiterman closed 6 years ago

BobLiterman commented 6 years ago

This version of SISRS works from top to bottom with the test data and uses the newer streaming file handling protocols.

rachelss commented 6 years ago

@anderspitman why does Travis fail and can we fix it?

BobLiterman commented 6 years ago

@anderspitman may know?

anderspitman commented 6 years ago

You can click on the Details link to see the output from the run. As discussed in #36, the tests (tests/test_sisrs.py) and test data are going to have to be updated to match the changes made by @BobLiterman. It's best to keep that in sync as you go along, making sure the tests still pass before each commit. If you haven't been doing that it might be pretty painful to figure out why it's failing. Also you'll need to be very careful when making changes to tests and test data because if you've introduced any bugs regenerating the test data is dangerous.

anderspitman commented 6 years ago

Basically the passing test suite is our single source of truth. Anything committed to the repo needs to conform to it. It's ok for the test suite to be updated, but that process has to be done carefully and heavily audited, like amending the constitution.