search

racke / Template-Flute

Template::Flute - Modern designer-friendly HTML templating Engine
Other
11 stars 12 forks source link

Add more tests for Template::Flute::Iterator::JSON #116

Closed paultcochrane closed 9 years ago

paultcochrane commented 9 years ago

I noticed that the code coverage for Template::Flute::Iterator::JSON was at roughly 33% and thought I'd add some more tests. These tests bring the coverage over 90%. I've got a few questions about the remaining parts of the code, which I'll ask via IRC when I get the time (and you have time, of course!).

Comments or questions about the PR are most certainly welcome!

racke commented 9 years ago

Excellent, thanks. It might be also interesting to test whether it handles files with UTF-8 content correctly. Please continue with adding test coverage, that is really useful. Especially as I plan to migrate Template::Flute to using Moo.