D-10651 - Search '%2B' returns a 500, should return a 400

[usnavi]

• Empty search categories (any plus with no term following it, or is immediately followed by a plus) now return a 400

NOTE: previously, any search query with a trailing '+' threw a 500, however, a search of '++term1' would return, with only 'term1' categories, not a 500.

This PR now has the following return a 400:

• '+'
• '+cat1+'
• '++cat1'

Is this a no-no because some customer might already being using #3 and getting results, and this would be a 'regression'?

[shintasmith]

I don't think we should allow '++cat1'. That doesn't seem right. So I think we need to do this, but it would be good to know if anyone is using '++cat1' format in Prod. If there are some users using that format, we'll have to contact them proactively and tell them that we will break them.

[shintasmith]

Another question I have is that do we need to modify the rest of the Adapters? Do they support category searches?

[usnavi]

@shintasmith - I grepped our access logs, no one is submitting searches with '++' (%2B%2B).

Also, we don't have to worry about porting fixes to the other adapters. We can move them in a later story.

[shintasmith]

Sounds good.