search

rackerlabs / auter

Automatic updates for RHEL, Debian, and their derivatives, with the ability to run pre/post hooks & reboot afterwards.
Apache License 2.0
65 stars 18 forks source link

Make post-reboot script delay configurable #205

Closed rhodesn closed 5 years ago

rhodesn commented 5 years ago

During testing, and other times, it is useful to set a delay shorter than the currently hardcoded 5 minutes.

It's not documented in auter.conf, however it should be pretty clear to anyone able to read the auter script that it can be overridden in auter.conf.

rhodesn commented 5 years ago

I'd argue that it's on the user to validate their requirements correctly, just as with Apache MaxRequestWorkers and MySQL innodb_buffer_pool_size. Silently overriding user configuration will also cause some confusion.

reaperzn commented 5 years ago

@nrhodes91 Sorry, I just saw this now, So you are correct in that we should not be adjusting values silently, we should definitely add a message to the check. possibly something like:

if ([[ ${POSTREBOOTDELAY} -lt 120 ]] || [[ ${POSTREBOOTDELAY} -gt 1800 ]]); then
  ${POSTREBOOTDELAY}=300
  logit "WARNING: POSTREBOOTDELAY value (${POSTREBOOTDELAY}) set out of range (<120 or >1800). Using the default value of 300"
fi 
tty -s || sleep ${POSTREBOOTDELAY}

If we are going to expect the user to validate this themselves then we should at least add documentation around the potential impacts of setting this value too high or too low, keeping in mind that some users may easily overlook (as we initially did) some of the considerations that led us to implementing this delay in the first place.