search

rackerlabs / canon

A front-end framework for fast & consistent development of Rackspace UIs.
http://rackerlabs.github.io/canon/
Other
30 stars 22 forks source link

Gemfile: add jekyll #179

Closed buhman closed 7 years ago

buhman commented 7 years ago

There is a reference to this in Gemfile.lock, however this is not actually installed without it actually being present in the Gemfile, as it is not a dependency of any other gem.

eddywashere commented 7 years ago

It's part of the github-pages gem. Tucked away here: https://github.com/github/pages-gem/blob/master/lib/github-pages/dependencies.rb

If you're thinking about a jekyll upgrade, it would worth verifying the markdown parser handles the existing content correctly.

buhman commented 7 years ago

It's part of the github-pages gem

I'm slightly confused--it doesn't seem like github-pages is installed during script/bootstrap.

eddywashere commented 7 years ago

It should be part of bundle install - https://github.com/rackerlabs/canon/blob/master/script/bootstrap#L91-L94. Unless something got untagged in rubygems. Is that not working for you?

eddywashere commented 7 years ago

@buhman if you'd like to chat about stuff I'm in #canon-dev on irc or #canon-bootstrap in rackspace slack.

buhman commented 7 years ago

Is that not working for you?

Ahh. I figured it out--jekyll was not installed during the original bundle install because safe_yaml wasn't installed; with the new Gemfile.lock, the problem is more obvious:

Bundler could not find compatible versions for gem "safe_yaml":
  In snapshot (Gemfile.lock):
    safe_yaml (= 1.0.4)

  In Gemfile:
    github-pages was resolved to 14, which depends on
      jekyll (= 1.4.3) was resolved to 1.4.3, which depends on
        safe_yaml (~> 0.9.7)

Due to #177, we need to upgrade jekyll as well.

According to https://github.com/jekyll/jekyll/commit/3744e70128d18a07af10b11091342b0b8967ba37, this would need to be >=2.0.0.