Closed chri2547 closed 6 years ago
We had decided to place it before specs, but I’m fine with moving it into specs. I thinking it does make more sense to have within specs.
Will let you know when done!
From: "Bart Renner (Michael Barton Renner)" notifications@github.com Reply-To: rackerlabs/design-system reply@reply.github.com Date: Tuesday, August 7, 2018 at 4:15 PM To: rackerlabs/design-system design-system@noreply.github.com Cc: Christopher Moyer Christopher.Moyer@rackspace.com, Author author@noreply.github.com Subject: Re: [rackerlabs/design-system] Simple buttons - grayline updates (#565)
@palindromebart commented on this pull request.
other than the one IA question, the grayline images LGTM
In _component_design/buttons-simple.mdhttps://github.com/rackerlabs/design-system/pull/565#discussion_r208384803:
+{% figure [caption:"Simple button types"] [class:"image bg-light border"] %}
+
+{% endfigure %}
+
+{% endcolumn %}
+
+
+
+
+
+
+
+
+
+{% column left:"hxCol hxSpan-12-xs hxSpan-12-sm hxSpan-8-md hxSpan-8-lg" %}
+
button labels should go below the specifications, shouldn't it?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/rackerlabs/design-system/pull/565#pullrequestreview-144184197, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ah0huuxdokhn7yi3mJS-MpzpzIm2LvFcks5uOgNUgaJpZM4VuFPb.
spacing large button grayline label line is too long
@palindromebart, the style visual has been updated. We're ready for content-LGTM.
LGTM (with comments)