Simple buttons - grayline updates

chri2547 commented 6 years ago

We had decided to place it before specs, but I’m fine with moving it into specs. I thinking it does make more sense to have within specs.

Will let you know when done!

From: "Bart Renner (Michael Barton Renner)" notifications@github.com Reply-To: rackerlabs/design-system reply@reply.github.com Date: Tuesday, August 7, 2018 at 4:15 PM To: rackerlabs/design-system design-system@noreply.github.com Cc: Christopher Moyer Christopher.Moyer@rackspace.com, Author author@noreply.github.com Subject: Re: [rackerlabs/design-system] Simple buttons - grayline updates (#565)

@palindromebart commented on this pull request.

other than the one IA question, the grayline images LGTM

+{% figure [caption:"Simple button types"] [class:"image bg-light border"] %}

+

+{% endfigure %}

+

+{% endcolumn %}

+

+{% column left:"hxCol hxSpan-12-xs hxSpan-12-sm hxSpan-8-md hxSpan-8-lg" %}

+

Button labels

button labels should go below the specifications, shouldn't it?

palindromebart commented 6 years ago

spacing large button grayline label line is too long

chri2547 commented 6 years ago

@palindromebart, the style visual has been updated. We're ready for content-LGTM.

palindromebart commented 6 years ago

LGTM (with comments)