search

rackerlabs / design-system

Design documentation for Helix, the Rackspace Design System
11 stars 14 forks source link

Choice tiles new IA and content updates #610

Closed chri2547 closed 5 years ago

chri2547 commented 5 years ago

image

palindromebart commented 5 years ago

Need to change the name of this component to Option Tile, per bowling decision on May 15th 2018. this way we're aligned with HelixUI naming

cyrichardson commented 5 years ago

@chri2547 On it.

cyrichardson commented 5 years ago

@chri2547 Suggested changes here: helix_choice-tiles_cyrEdits.docx

cyrichardson commented 5 years ago

@chri2547 Sorry I picked up the wrong one. On one suggested for options tiles here: helix_option-tiles_cyrEdits.docx

palindromebart commented 5 years ago

Ship it, Squirrel!

chri2547 commented 5 years ago

Sounds good. This section no longer exists.

From: Laura Santamaria notifications@github.com Reply-To: rackerlabs/design-system reply@reply.github.com Date: Thursday, February 7, 2019 at 4:03 PM To: rackerlabs/design-system design-system@noreply.github.com Cc: Christopher Moyer Christopher.Moyer@rackspace.com, Mention mention@noreply.github.com Subject: Re: [rackerlabs/design-system] Choice tiles new IA and content updates (#610)

@nimbinatus dismissed review on this pull request.

In _docs/style/focus-states.mdhttps://github.com/rackerlabs/design-system/pull/610#discussion_r254882981:

@@ -364,7 +364,7 @@ The beacon comes with a glow baked in, so when it receives focus, the existing g

Focusable containers

-Some elements, such as [Choice Tiles]() feature a clickable container. In these cases, focus is applied to the entire container, according to normal focus rules.

+Some elements, such as [Option Tiles]() feature a clickable container. In these cases, focus is applied to the entire container, according to normal focus rules.

If the removal is part of the focus states PR that was merged, I would still see it here until we merge that PR (i.e., until the branch merges into staging and then those changes appear here). I can draw you a graph sometime to explain it. But I'll take it this one is resolved.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/rackerlabs/design-system/pull/610#pullrequestreview-201342745, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ah0hupZrtyhvPi6uin-Mlpau0l2kEvQ-ks5vLKKegaJpZM4ZosQK.