Docs: Include design pattern of editing inline

rackerlabs / encore-ui

UI Framework for Encore

http://rackerlabs.github.io/encore-ui/

Other

48 stars 46 forks source link

Docs: Include design pattern of editing inline #1638

Open ErnieAtLYD opened 8 years ago

ErnieAtLYD commented 8 years ago

As an example in billing:

100stacks commented 8 years ago

@ErnieAtLYD @glynnis is this something we need to capture in the Framework, or does this need to go through REDD first?

ErnieAtLYD commented 8 years ago

I actually got this design pattern from someone at REDD (@Deathrow76) https://projects.invisionapp.com/share/HU6WG4WNZ#/screens/139135572

glynnis commented 8 years ago

@ErnieAtLYD Can you be more specific with what you want to see documented that isn't already covered by http://rackerlabs.github.io/encore-ui/#/components/rxMetadata? The InVision link you included doesn't really show inline editing, but rather shows a link that opens a modal.

Just looking for some clarity so I understand what needs to be done before I move this over to the Framework board. Thanks!

ErnieAtLYD commented 8 years ago

@glynnis Sure:

This (Add) is for, oh hey, adding. But what about if we need to Delete? Do we use Edit? I listed a bunch of options for Billing EOD-1450.
"I would honestly expect it to be a pencil icon that creates the modal with the option to delete it altogether." - Alex B.
"I think historically they’ve always been separate actions rather than combined into a single modal." - Glynnis (and Steven)
Note that the (Add) and (Edit) links go to a modal dialogue. Would we make the whole metadata entry a link if it wasn't a modal?

glynnis commented 8 years ago

Received an updating from @ErnieAtLYD that this is going to go through a Billing/user-testing process.

@ErnieAtLYD please report back here when you have results, and we can get a story made in JIRA to make whatever changes you require.

ErnieAtLYD commented 8 years ago

Update: due to Project Management needing to prioritize urgency, we have had to bypass user testing for now to deliver a solution. This solution was posted at https://invis.io/CM779EY35 .

ErnieAtLYD commented 7 years ago

Billing user testing process have been completed although tbh there wasn't really much breakthroughs one way or another. I would make the argument to put this on FRAMEWORK as planned. Also worked on EOD-1657 (internal link) which shows what happens if you don't have the proper permissions.

Additionally, I would suggest to remove @glynnis as she's no longer on the team.

ErnieAtLYD commented 7 years ago

also cc-ing: @CITguy as he may be interested with the updated events in this thread.

glynnis commented 7 years ago

ErnieAtLYD commented 7 years ago

@glynnis: I mean, unless you want to get Rackspace notifications forever. No complaints from me. ;)

glynnis commented 7 years ago

Sorry, not helping 😸 I'm just here to troll