rackerlabs / kthresher

Tool to remove unused kernels in Debian/Ubuntu
Apache License 2.0
17 stars 12 forks source link

No default action when running kthresher #66

Closed tonyskapunk closed 5 years ago

tonyskapunk commented 5 years ago

In https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919457 it was found that kthresher was printing out the help content through cron when no configuration to take an action was defined. That was tackled with #59 and while that avoids printing the help to the cronjob/timers it does not solve the user experience when running kthresher on its own.

I've been talking about this with @jkirk (Debian package maintainer) and we believe that the -s,--show-autoremoval action is probably a better default action.

It is also some dialog going about the implementation in #59 about "hiding" the output from a cronjob/timer. I personally would like to avoid the noise of a daily email but I do see the importance of notifications. Seems then that #58 provides both of the best options moving out the noisy emails to the logs with a simple entry stating the actions or not from the run.

tonyskapunk commented 5 years ago

Fixed on #67