search

rackerlabs / lambda-uploader

Helps package and upload Python lambda functions to AWS
Apache License 2.0
270 stars 56 forks source link

[HELP] Use existing virtual env instead of requirements.txt #166

Closed BeyondEvil closed 5 years ago

BeyondEvil commented 5 years ago

We use pipenv which has a Pipfile instead of a requirements.txt.

Is it possible to use the existing venv or have lamda-uploader use the Pipfile?

I'm happy to contribute a PR with some guidance.

jarosser06 commented 5 years ago

Lambda Uploader doesn't support a Pipfile just a requirements file. You should however be able to use an existing virtualenv though. Use --virtualenv or -e to specify the existing virtualenv location.

If you want to create a PR for the Pipfile I would be happy to take a look.

On Wed, Jun 5, 2019, 06:44 Jim Brännlund notifications@github.com wrote:

We use pipenv https://docs.pipenv.org/en/latest/ which has a Pipfile instead of a requirements.txt.

Is it possible to use the existing venv or have lamda-uploader use the Pipfile?

I'm happy to contribute a PR with some guidance.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rackerlabs/lambda-uploader/issues/166?email_source=notifications&email_token=AAPLRI2X42V2OSUAHUAO5G3PY6YMDA5CNFSM4HTXCPC2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GXYJYWQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPLRIYNIGFB62W2K2DFOU3PY6YMDANCNFSM4HTXCPCQ .

BeyondEvil commented 5 years ago

Ok, sounds good!

I’ll check to see what level of work is required to make that happen. Without having looked at it at any depth, I’m afraid it would require lambda-uploader to have the entire pipenv lib as a dependency, which seems like overkill since there is a ”workaround” available. On 5 Jun 2019, 16:21 +0200, Jim Rosser notifications@github.com, wrote:

Lambda Uploader doesn't support a Pipfile just a requirements file. You should however be able to use an existing virtualenv though. Use --virtualenv or -e to specify the existing virtualenv location.

If you want to create a PR for the Pipfile I would be happy to take a look.

On Wed, Jun 5, 2019, 06:44 Jim Brännlund notifications@github.com wrote:

We use pipenv https://docs.pipenv.org/en/latest/ which has a Pipfile instead of a requirements.txt.

Is it possible to use the existing venv or have lamda-uploader use the Pipfile?

I'm happy to contribute a PR with some guidance.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rackerlabs/lambda-uploader/issues/166?email_source=notifications&email_token=AAPLRI2X42V2OSUAHUAO5G3PY6YMDA5CNFSM4HTXCPC2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GXYJYWQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPLRIYNIGFB62W2K2DFOU3PY6YMDANCNFSM4HTXCPCQ .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

BeyondEvil commented 5 years ago

As I was afraid, the parser is not a standalone module.