search

rackerlabs / lambda-uploader

Helps package and upload Python lambda functions to AWS
Apache License 2.0
272 stars 56 forks source link

Fixing the infamous ResourceConflictException #170

Closed odeckmyn closed 2 years ago

odeckmyn commented 2 years ago

Based on rriifftt implementation I've added another wait and fixed the bug for my usage.

This PR solves everything for me.

rriifftt commented 2 years ago

@odeckmyn I see it need waiter for publish_version() after update_function_configuration() process too.

it seems like add waiter method in this class is better..? but the way, looks good to me.

odeckmyn commented 2 years ago

@odeckmyn I see it need waiter for publish_version() after update_function_configuration() process too.

it seems like add waiter method in this class is better..? but the way, looks good to me.

To be honest I don't know :-) Feel free to make any modification. In my case, these patches solved my issue. And your work made my day :-)

rriifftt commented 2 years ago

@odeckmyn sounds good. Well, I don't have the authority to merge...

jarosser06 commented 2 years ago

I don't maintain this anymore, partially b/c I'm no longer at Rackspace, and partially b/c I no longer use the tool itself for anything other than a library for my own workflow.

I'll ping a buddy of mine still at Rackspace to take a look at this PR.

gdelvalle commented 2 years ago

I'll try to get this handled for you guys. Give me a few days to free up so I can properly review thee project, this problem and the proposed solution. At a glance it seems reasonable.

rriifftt commented 2 years ago

@gdelvalle Is it likely that this case cannot be merged?

rriifftt commented 2 years ago

Thanks for Reviewing

gdelvalle commented 2 years ago

Release: https://github.com/rackerlabs/lambda-uploader/releases/tag/v1.3.1