If you pass a directory in for the configuration file parameter, we should probably try to use it

rackerlabs / lambda-uploader

Helps package and upload Python lambda functions to AWS

Apache License 2.0

271 stars 56 forks source link

If you pass a directory in for the configuration file parameter, we should probably try to use it #76

Closed martinb3 closed 8 years ago

martinb3 commented 8 years ago

Right now, if the file doesn't exist (e.g. if it's a directory), we try the current directory and join lambda.json to it. Should we consider trying the supplied path given as an argument, and joining lambda.json to that first.

DeviaVir commented 8 years ago

Possible breadcrumb: https://github.com/rackerlabs/lambda-uploader/pull/74#discussion_r57307712

jarosser06 commented 8 years ago

Discussing this offline. I feel like the lambda-uploader shouldn't behave like this. If someone is overriding the configuration file default "/path/of/function/lambda.json" then it should explicitly point to a configuration file. If a directory is passed then it is not a configuration file and an exception should be raised.