search

rackerlabs / mimic

An API mock service
Other
168 stars 57 forks source link

Implement nova get_version #619

Closed Benjamin91300 closed 8 years ago

Benjamin91300 commented 8 years ago

Recent novaclient versions and openstackclient require resource /compute/v2. This commit provides it.

BenjamenMeyer commented 8 years ago

Along with #618 this should resolve #511

glyph commented 8 years ago

Please just address the minor test doc issue and land.

Benjamin91300 commented 8 years ago

@glyph, @BenjamenMeyer: I added a reference to the nova doc in docstring.

I hope it is what you expected.

BenjamenMeyer commented 8 years ago

@Benjamin91300 I would add it to the handler of the response itself, not simply the test (https://github.com/rackerlabs/mimic/pull/619/files#diff-623976324cdaaa34626dd686efc298b9R34).

Once that and the current merge conflict are resolved then I'll merge it as it otherwise LGTM.

BenjamenMeyer commented 8 years ago

:+1: