search

rackerlabs / mimic

An API mock service
Other
167 stars 57 forks source link

Adding Alarm Change Log End point #628

Closed rgangal closed 8 years ago

rgangal commented 8 years ago

This Pull requests add Alarm change log end point which is needed for All Alerts feature of Rackspace Intelligence.

codecov-io commented 8 years ago

Current coverage is 99.53%

Merging #628 into master will increase coverage by <.01%

@@             master       #628   diff @@
==========================================
  Files            77         77          
  Lines          4978       4984     +6   
  Methods           0          0          
  Messages          0          0          
  Branches        679        680     +1   
==========================================
+ Hits           4955       4961     +6   
  Misses           10         10          
  Partials         13         13

Powered by Codecov. Last updated by 0987176...668bd4d

glyph commented 8 years ago

Hi @raghav3259 - this is in fairly good shape, but needs a few minor tweaks. Would you mind addressing them? Thanks!

rgangal commented 8 years ago

@glyph : thanks for reviewing . I have addressed the issues. Kindly let me know if anything else need to be done?

glyph commented 8 years ago

Looks fine, just waiting on the CI results now, I think.