Enhancement osksadm credentials also

rackerlabs / mimic

An API mock service

Other

168 stars 57 forks source link

Enhancement osksadm credentials also #639

Closed BenjamenMeyer closed 8 years ago

BenjamenMeyer commented 8 years ago

Mimic supported looking up the API Key of a user via /v2.0/users/<userid>/OS-KSADM/credentials/RAX-KSKEY:apiKeyCredentials; however, tools like pyrax had support for doing the generic credentials lookup via /v2.0/users/<userid>/OS-KSADM/credentials which Mimic was not supporting. This adds the additional functionality so that either method can be used. It also includes a separate API key when doing so to aid with debugging, and also provides a similar password credentials.

codecov-io commented 8 years ago

Current coverage is 99.53%

Merging #639 into master will increase coverage by <.01%

@@             master       #639   diff @@
==========================================
  Files            77         77          
  Lines          4984       4998    +14   
  Methods           0          0          
  Messages          0          0          
  Branches        680        681     +1   
==========================================
+ Hits           4961       4975    +14   
  Misses           10         10          
  Partials         13         13

Powered by Codecov. Last updated by 217000e...7fdaecc

glyph commented 8 years ago

@BenjamenMeyer - this is mostly pretty good; if you can address the inline comments I made to your own satisfaction I think you can go ahead and land.

glyph commented 8 years ago

/me wearily checks https://codecov.statuspage.io to see what's going on this time, but sees nothing...

glyph commented 8 years ago

Hey @codecov-io - any idea why this PR's coverage isn't getting reported?

BenjamenMeyer commented 8 years ago

@glyph let's merge PR #618 before this one so @Benjamin91300 doesn't have to do another rebase.

BenjamenMeyer commented 8 years ago

@glyph merged latest from trunk; ready to review again as soon as it passes gates.

BenjamenMeyer commented 8 years ago

Given:

https://github.com/rackerlabs/mimic/pull/639#issuecomment-225781324 and associated labels
resolutions to above satisfied by https://github.com/rackerlabs/mimic/pull/639/commits/60dc50806cb3b5f4410d4644983e18c473bc1ef1
only master merges since for sake of github's merge functionality

It seems like this branch is ready for merge.

BenjamenMeyer commented 8 years ago

@glyph codecov seems stuck again.

@codecov-io

glyph commented 8 years ago

Looks like codecov came unstuck? Thanks for taking care of this :)