rackerlabs / mimic

An API mock service
Other
167 stars 57 forks source link

Mimic specific vimrc file #721

Closed manishtomar closed 7 years ago

manishtomar commented 7 years ago

which comes into effect when opening any file in this directory. Currently, it only colors 105 column.

codecov-io commented 7 years ago

Current coverage is 99.60% (diff: 100%)

Merging #721 into master will not change coverage

@@             master       #721   diff @@
==========================================
  Files            79         79          
  Lines          5564       5564          
  Methods           0          0          
  Messages          0          0          
  Branches        784        784          
==========================================
  Hits           5542       5542          
  Misses           10         10          
  Partials         12         12          

Powered by Codecov. Last update 78a54c8...ba9fe65

glyph commented 7 years ago

I understand the desire for automatic project-specific configuration, but I really do not want to encourage the use of a horribly insecure plugin to achieve this. (vim should not execute code from the current directory).

glyph commented 7 years ago

I feel a little bad closing this PR, since I agree the metadata is useful, but unless there's some way to make this type of execution safe, I feel like it would be irresponsible to add it to the project. So for now at least, closing.

manishtomar commented 7 years ago

Hmm. Since this file is only executed by the plugin wouldn't the developer have made the decision about its security before this file is actually executed?

glyph commented 7 years ago

@manishtomar My point isn't that Mimic might somehow subvert their security, but rather that I don't want to encourage this plugin's use, because it is doubtful that the developer has thoughtfully evaluated it. For example, would you expect cd Downloads/some-weird-thing; vi textfile.txt to execute arbitrary code?

manishtomar commented 7 years ago

For example, would you expect cd Downloads/some-weird-thing; vi textfile.txt to execute arbitrary code?

Most definitely not. After browsing about this I am now concerned about the plugins I've installed 😕 They aren't much but I'll check them. Thanks for the perspective.