search

rackerlabs / mimic

An API mock service
Other
167 stars 57 forks source link

Cloudfeeds customer access events #726

Open manishtomar opened 7 years ago

manishtomar commented 7 years ago

Implement API to provide customer access events in cloud feeds format. This is based on https://one.rackspace.com/display/CUST/Access+Policy.

codecov-io commented 7 years ago

Codecov Report

Merging #726 into master will decrease coverage by -0.03%. The diff coverage is 97.61%.

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
- Coverage    99.6%   99.57%   -0.03%     
==========================================
  Files          79       80       +1     
  Lines        5564     5648      +84     
  Branches      784      795      +11     
==========================================
+ Hits         5542     5624      +82     
- Misses         10       11       +1     
- Partials       12       13       +1
Impacted Files Coverage Δ
mimic/resource.py 100% <100%> (ø) :white_check_mark:
mimic/core.py 100% <100%> (ø) :white_check_mark:
mimic/rest/cloudfeedscap.py 97.46% <97.46%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4fcbbed...61ce221. Read the comment docs.

manishtomar commented 7 years ago

@glyph sorry I abandoned this :(

glyph commented 7 years ago

@manishtomar No worries! It was closer to finished than I realized. Now we just have to wait 2 or 3 weeks for the Mac build to complete: https://www.traviscistatus.com/#metrics-display-graph-container-7cl94r33fvsg

glyph commented 7 years ago

The one coverage issue here is that there needs to be a test for a direction query parameter other than forwards or backwards.

glyph commented 7 years ago

If someone else would like to move this forward, it just needs test coverage.

manishtomar commented 7 years ago

@glyph I'll get this done this week.

manishtomar commented 7 years ago

@glyph I can't commit to this branch. Is it possible to give me permission for this repo temporarily?

BenjamenMeyer commented 7 years ago

@manishtomar are you not doing this under your own fork? That would be the best way to do it. Otherwise @lekhajee will probably have to help you out.

lekhajee commented 7 years ago

@manishtomar : Have added you as a collaborator.

glyph commented 7 years ago

Thanks @lekhajee ! Now it's totally on you, @manishtomar :)

manishtomar commented 7 years ago

@lekhajee It still shows me a "contributor" instead of "collaborator". interestingly it shows you also as "contributor". Can you please check again?

@manishtomar are you not doing this under your own fork? That would be the best way to do it. Otherwise @lekhajee will probably have to help you out.

@BenjamenMeyer You are right. I should be doing that. It's just that I had committed to this branch and then left rackerlab repo. Now I've a very simple commit to finish the PR and was hoping to add it here instead of creating new PR from fork.